-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes Senior Roles #25
Removes Senior Roles #25
Conversation
This commit name sounds extremely wrong.
The real question is, do we want them to be potentially late join or entirely gone? |
Looks like we may have to comment out senior roles on maps. I can get started on it in a few minutes. |
I think entirely gone is probably the route to take. We have no desire to really keep them in game. We'll just comment them out until we decide otherwise. |
I'll deal with entirely commenting out the senior roles then. |
Nyano does have some code that touches late join. Rane did something so roles like Prisoner/Gladiator/etc spawn where the marker is and not at the late join spot in arrivals. Not sure if that's relevant here or not. |
Do not. This is because of the stations |
Comment them out in the station prototypes, not the jobs themselves |
Right, that's what I meant haha. |
Recent merge added back incorrect entries into the map prototypes |
About the PR
It comments out all the senior roles and set the ability to set their preference to false.
Why / Balance
Technical details
Media
Breaking changes
Changelog
🆑